array_diff_multidimensional helper function

[rogervila]

Adds a global array_diff_multidimensional() helper function.

$new = [
	'a' => 'b',
	'c' => [
		'd' => 'e',
		'f' => 'Hello',
	],
];

$old = [
	'a' => 'b',
	'c' => [
		'd' => 'e',
		'f' => 'Goodbye',
	],
];

$result = array_diff_multidimensional($new, $old);

var_dump($result);

// [
// 	'c' => [
// 		'f' => 'Hello'
//  	],
// ]

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[shadowhand]

It bothers me that this is defined as a global function instead of a function in the Rogervila namespace.

[rogervila]

Hi @shadowhand, this is an interesting point of view.

The idea is to have access to array_diff_multidimensional() the same way as PHP's native array_diff() function.

Since the original class is already namespaced, it can be used in case there is a conflict with the global helper.

Anyway, if you find a corner case related to the global helper function, do not hesitate to open an issue or even a PR.

Thank you very much for your feedback!

[shadowhand]

@rogervila my reasoning is pretty simple: array_diff_multidimensional is not a native PHP function and so putting it in the global (root) namespace doesn't make sense to me.

I have no problem with having a helper function, but using a polyfill approach ( if (! function_exists(...)) ) basically proves my point, the global namespace shouldn't be polluted with arbitrary functions.