Version 2

[rogervila]

• PHP 8 Support (Remove support for old PHP versions if necessary)
• Integrate PRs by @ioanszabo (Remove parameter check from each iteration #4, Moved second array check outside loop. #6)
• Integrate PRs by @aburakovskiy (Fix problem with comparing float values #2)
• Strict comparison by default
• strictComparison() and looseComparison() methods

[aburakovskiy]

Is it necessary to compare types too?
What is an expected result for comparing these two arrays: ['a' => 1] and ['a' => '1']
What if the compare method has the 3rd parameter $strict = true?

[rogervila]

Hi,

The example you exposed could be a bug detection in a codebase where an integer is converted by error to a string, or vice-versa.

IMO strict comparisons should be the only comparison type to use since 1 is totally different to '1'

Anyway, if using a loose comparison method is a required feature, I will not remove it.

I agree with adding a 3rd parameter, but since version 2 is a great opportunity for breaking changes, it will be true by default.

I will also add specific methods like strictCompare() and looselyCompare() since they look clearer for me.

Thank you very much for your suggestion.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication