fix(point annotation): selected property should select/deselect#4165
Merged
fix(point annotation): selected property should select/deselect#4165
Conversation
…nt annotation Co-Authored-By: Miklós Fazekas <mfazekas@szemafor.com>
Callout children were mounted into the ComponentView instead of the contentView (RNMBXCallout), producing a transparent snapshot. Override mountChildComponentView in RNMBXCalloutComponentView to insert children into the contentView. Also set iconAllowOverlap on the callout annotation manager so callouts are not hidden by symbol collision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #4036 on current main. Adds
selectedprop to PointAnnotation to programmatically select/deselect annotations. Drops old-arch changes (no longer needed) and adapts iOS ComponentView to use macro-based prop conversion.Also fixes callout not rendering on iOS (Fabric) — children were mounted into the ComponentView instead of the contentView, producing transparent snapshots.
Fixes #4034
Closes #4036
Minimal reproducer
Full example (ShowPointAnnotation.tsx)