feat: use env variable RNMAPBOX_MAPS_DOWNLOAD_TOKEN to provide downl…#4010
Merged
feat: use env variable RNMAPBOX_MAPS_DOWNLOAD_TOKEN to provide downl…#4010
Conversation
mfazekas
force-pushed
the
feat/support-rnmapbox-maps-download-token-env
branch
from
38097b0 to
24ee25e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3396
We've allowed to specify RNMapboxMapsToken in expo plugin config file. That's not ideal as those are exposed in built .apk/.app.
Such tokens should be defined in env variables, which is now supported via
RNMAPBOX_MAPS_DOWNLOAD_TOKENenvironment variable and the oldRNMapboxMapsTokenis now deprecatedSee #3396 and expo/sentry-expo#321, and expo/sentry-expo#321 (comment)
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing