feat: support multiple macOS instance families in a single ASG#196
Open
cchristous wants to merge 1 commit intorenderedtext:masterfrom
Open
feat: support multiple macOS instance families in a single ASG#196cchristous wants to merge 1 commit intorenderedtext:masterfrom
cchristous wants to merge 1 commit intorenderedtext:masterfrom
Conversation
Allow SEMAPHORE_AGENT_MAC_FAMILY to accept comma-separated values (e.g. "mac2,mac2-m2") so a single ASG can launch instances across different Mac hardware generations. The host resource group is configured with all specified families, and launch template overrides are auto-generated from the family list. Combined with the "prioritized" on-demand allocation strategy, the ASG will prefer the first family in the list and fall back to subsequent ones.
Contributor
|
/sem-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEMAPHORE_AGENT_MAC_FAMILYto accept comma-separated values (e.g.mac2,mac2-m2,mac2-m2pro) so a single ASG can launch instances across different Mac Dedicated Host families.metalinstance typeallowed-host-familiesis updated to include all specified familiesWhy this is safe
mac2), behavior is unchanged —getAsList()on a single value returns a one-element array, producing the same result as beforeSEMAPHORE_AGENT_ASG_LAUNCH_TEMPLATE_OVERRIDES_JSONas beforeSEMAPHORE_AGENT_ON_DEMAND_ALLOCATION_STRATEGY=prioritized, the ASG will prefer the first family in the list and fall back to subsequent ones only when no hosts of the preferred family are availableTest plan
auto-host-recoveryparameter (was missing after previous commit)allowed-host-familiesand launch template overridesprioritizedallocation strategy with multiple families verifies correct override order and distribution config