Have Site initialize a SiteMap and update during render.#1118
Merged
kjaymiller merged 1 commit intomainfrom Mar 11, 2026
Merged
Have Site initialize a SiteMap and update during render.#1118kjaymiller merged 1 commit intomainfrom
Site initialize a SiteMap and update during render.#1118kjaymiller merged 1 commit intomainfrom
Conversation
github-actions
bot
added
bug
kjaymiller
approved these changes
Mar 11, 2026
kjaymiller
pushed a commit
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1072
SiteMapconstructor.SiteMap.site_urlto propertyupdatetoSiteMapSitewith, effectively, an emptySiteMapSiteMapduringrendersite_urltorender(this is for the API to be able to produce the site map with the correct URL for local serving.)Type of Issue
Changes have been Documented (If Applicable)
IMO documentation is not needed as the user should not be mucking around with this. This change should be transparent to the user.
Changes have been Tested
Functionally, there is no change that requires additional testing. The change to the test file was due to my reordering the parameters for the
SiteMapconstructor during work.Next Steps
Update the CLI to use the correct local URL when running
serve,AI Attestation
No AI used in the creation of this PR.