Closed
Conversation
Contributor
Author
|
@TomasVotruba, @samsonasik please see driftingly/rector-laravel#466, something in the last release (either in rector or phpstan) is causing both this ci to fail and rector-laravel to fail I will continue to dig on my end |
calebdw
force-pushed
the
calebdw/push-pqkkozvwtloq
branch
2 times, most recently
from
c38c47c to
408db5d
Compare
calebdw
force-pushed
the
calebdw/push-pqkkozvwtloq
branch
2 times, most recently
from
2babcc9 to
819efa6
Compare
Contributor
Author
|
@TomasVotruba, @samsonasik the problem seems to be in these last 2 commits: 
Reverting them (and pinning the phpstan version to 2.1.33) allows the PHP Tests to pass (the other tests are related to the other packages likely pulling in the latest phpstan) 
|
calebdw
force-pushed
the
calebdw/push-pqkkozvwtloq
branch
2 times, most recently
from
a3c8336 to
5973fa7
Compare
calebdw
force-pushed
the
calebdw/push-pqkkozvwtloq
branch
from
5973fa7 to
6b47f43
Compare
Member
|
@calebdw I will check in separate PR :) The rector-downgrade-php already phpstan 2.1.35 |
Member
|
@calebdw I created 2 PRs that show that in PHPStan 2.1.34 (working), and PHPStan 2.1.35 (not working) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba, @samsonasik
Important
The problem appears to be in the latest PHPStan 2.1.35 release