Convert ObjectServerExample to Kotlin and use data binding#6413
Merged
Convert ObjectServerExample to Kotlin and use data binding#6413
Conversation
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/LoginActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/model/CRDTCounter.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/model/CRDTCounter.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
| } | ||
|
|
||
| fun incrementCounter(delta: Long) { | ||
| counter.increment(delta) |
Contributor
There was a problem hiding this comment.
Now I wonder why MutableRealmInteger doesn't get a += extension operator from io.realm.kotlin 😉
Contributor
Author
There was a problem hiding this comment.
Yes, we should do that 😄
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
Zhuinden
reviewed
Jan 28, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/LoginActivity.kt
Outdated
Show resolved
Hide resolved
cmelchior
commented
Jan 31, 2019
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Show resolved
Hide resolved
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/LoginActivity.kt
Outdated
Show resolved
Hide resolved
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/MyApplication.kt
Outdated
Show resolved
Hide resolved
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Outdated
Show resolved
Hide resolved
darrinps
reviewed
Jan 31, 2019
examples/objectServerExample/src/main/java/io/realm/examples/objectserver/CounterActivity.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done in order to have a example using Sync written in Kotlin
Internal: See https://realmio.slack.com/archives/C0E1CGS03/p1548449974015500?thread_ts=1548196688.011800&cid=C0E1CGS03