Do not use unbuffered reads on pipe streams for legacy PHP < 5.4#80
Merged
clue merged 1 commit intoreactphp:masterfrom Mar 13, 2017
Merged
Do not use unbuffered reads on pipe streams for legacy PHP < 5.4#80clue merged 1 commit intoreactphp:masterfrom
clue merged 1 commit intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Mar 12, 2017
jsor
approved these changes
Mar 13, 2017
This was referenced Aug 18, 2017
This was referenced Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, reading from a pipe stream (such as STDIN) causes SEGFAULTs on legacy PHP < 5.4.
I've added a very simple
cat.phpexample which highlights this issue.This patch avoids switching to unbuffered mode for pipe streams on PHP < 5.4 and thus avoids this issue on all versions. Technically, unbuffered reads aren't really needed here for any PHP version, but not using unbuffered reads shows a 10%-20% performance penalty.
Fixes #78