Cancellation handler must only be called once, ignore double cancellation#47
Merged
jsor merged 2 commits intoreactphp:masterfrom Feb 26, 2016
Merged
Conversation
Member
|
Thanks for spotting. This should be easy to fix. diff --git a/src/Promise.php b/src/Promise.php
index 75379ea..7af9943 100644
--- a/src/Promise.php
+++ b/src/Promise.php
@@ -91,7 +91,10 @@ class Promise implements ExtendedPromiseInterface, CancellablePromiseInterface
return;
}
- $this->call($this->canceller);
+ $canceller = $this->canceller;
+ $this->canceller = null;
+
+ $this->call($canceller);
}
private function resolver(callable $onFulfilled = null, callable $onRejected = null, callable $onProgress = null) |
Member
Author
Yeah, I already prepared the same fix for this issue, but figured I'd bring this up here first and confirm if this is actually the desired behavior. Documentation on cancellation behavior is scarce, also with respect to other promise implementors. FWIW, I've encountered this issue while implementing #48, to which I've just pushed the same update. This is now ready for review |
jsor
added a commit
that referenced
this pull request
Feb 26, 2016
Cancellation handler must only be called once, ignore double cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step, this ticket aims to document the current behavior. Following, we should fix the first test case and probably also reconsider the second one.
Opening this ticket as an RFC and for the reference.