Initialize Deferred's state in the constructor#171
Merged
jsor merged 1 commit intoreactphp:masterfrom Aug 19, 2020
Merged
Conversation
This change refactors out unnecessary and magical (= unclear, hard-to-understand) code from Deferred's methods and moves object state initialization where it belongs - to the constructor.
jsor
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change
This is a self-contained and atomic change. All tests pass with PHP 7.3.9 on Windows 10 Pro (the latter shouldn't make a difference).