UploadedFile implementing UploadedFileInterface#199
Merged
WyriHaximus merged 4 commits intoreactphp:masterfrom Jun 8, 2017
Merged
UploadedFile implementing UploadedFileInterface#199WyriHaximus merged 4 commits intoreactphp:masterfrom
WyriHaximus merged 4 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Jun 1, 2017
clue
reviewed
Jun 7, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
It's a bit unclear how this is going to be used, but if this is only a preparation for a follow-up PR, then I'm good with it as long as we avoid any BC breaks in the future 👍
| use Psr\Http\Message\UploadedFileInterface; | ||
| use RuntimeException; | ||
|
|
||
| final class UploadedFile implements UploadedFileInterface |
Member
There was a problem hiding this comment.
I don't see this class being used or documented anywhere, should this be marked @internal?
Member
Author
There was a problem hiding this comment.
It will be used in a follow up PR. Specifically the multipart bodyparser.
Member
Author
|
@clue this is a preparation PR for upcoming PR. Will mark the class internal soon 👍 |
clue
approved these changes
Jun 8, 2017
Member
|
Updated milestone because it's been released as part of v0.7.1 (as discussed in #201) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get started with the body parsers we first need an object representing uploaded files. This is a simple implementation of the PSR-7 UploadedFileInterface.
Supersedes #62