Validate proxy requests in absolute-form#169
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Apr 21, 2017
Merged
Conversation
clue
force-pushed
the
uris
branch
2 times, most recently
from
4808542 to
708b143
Compare
clue
changed the title
Member
Author
|
Updated PR to remove unrelated changes so this now has a clear focus on requests in |
jsor
approved these changes
Apr 20, 2017
WyriHaximus
requested changes
Apr 20, 2017
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
LGTM, just a minor nitpick
tests/ServerTest.php
Outdated
| $this->assertSame('http://example.com/test', $requestAssertion->getRequestTarget()); | ||
| $this->assertEquals('http://example.com/test', $requestAssertion->getUri()); | ||
| $this->assertSame('/test', $requestAssertion->getUri()->getPath()); | ||
| //$this->assertSame(array(), $requestAssertion->getQueryParams()); |
Member
There was a problem hiding this comment.
Any reason this is commented out? To me commented out code shouldn't be committed tbh
tests/ServerTest.php
Outdated
| $this->assertSame('http://example.com:8080/test', $requestAssertion->getRequestTarget()); | ||
| $this->assertEquals('http://example.com:8080/test', $requestAssertion->getUri()); | ||
| $this->assertSame('/test', $requestAssertion->getUri()->getPath()); | ||
| //$this->assertSame(array(), $requestAssertion->getQueryParams()); |
Member
Author
|
Thanks for spotting! Updated and also rebased now that #170 is in, which did not preserve original request-target |
WyriHaximus
approved these changes
Apr 21, 2017
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
absolute-formrequest-targetwas already supported in earlier version, but was neither tested nor documented. This PR makes sure thatgetUri()behaves consistent across different forms of request-target and adds matching documentation and an example for a plain HTTP proxy that relies on requests inabsolute-form.Example request as sent to a plain HTTP proxy:
Builds on top of #167, #158 and #157.