Documentation for high precision timers with millisecond accuracy or below#157
Merged
jsor merged 2 commits intoreactphp:masterfrom Mar 26, 2018
Merged
Documentation for high precision timers with millisecond accuracy or below#157jsor merged 2 commits intoreactphp:masterfrom
jsor merged 2 commits intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Mar 25, 2018
jsor
reviewed
Mar 26, 2018
| * that are subject to discontinuous time adjustments (time jumps). | ||
| * This means that if you schedule a timer to trigger in 30s and then adjust | ||
| * your system time forward by 20s, the timer SHOULD still trigger in 30s. | ||
| * See also [event loop implementations](#loop-implementations) for more details. |
Member
There was a problem hiding this comment.
The reference can probably omitted here in the docblock or link to README.md#loop-implementations
Member
Author
There was a problem hiding this comment.
Fair point. This only consistently applies the same changes from #130 to this method. Does it make sense for you to keep this as-is for now and look into all these references in a follow-up PR? 👍
jsor
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #130