Reject parsing malformed record data and incomplete DNS response messages#117
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Nov 11, 2018
Merged
Reject parsing malformed record data and incomplete DNS response messages#117WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Nov 6, 2018
WyriHaximus
approved these changes
Nov 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that each record data is valid according to its type, e.g. an
Arecord MUST always have a 4 byte IPv4 address. This should not affect normal operation of compliant DNS servers, but we now ensure that invalid response messages no longer cause any parsing errors on our side. I've added test cases to cover each possible parsing error so that this has 100% test coverage.Builds on top of #115