[WIP] Additional SSL/TLS context parameters#45
Closed
clue wants to merge 1 commit intoreactphp-legacy:masterfrom
Closed
[WIP] Additional SSL/TLS context parameters#45clue wants to merge 1 commit intoreactphp-legacy:masterfrom
clue wants to merge 1 commit intoreactphp-legacy:masterfrom
Conversation
This was referenced Sep 7, 2015
This was referenced Sep 23, 2015
clue
force-pushed
the
secure-context-parameters
branch
from
01932d0 to
cf2f5f4
Compare
Contributor
Author
|
I've just rebased this on the current master now that #43 is in. Ping @WyriHaximus, @cboden |
Contributor
|
Love this, LGTM 👍 |
Contributor
Author
|
For the reference: I've filed #52 as an alternative to this PR. This PR adds an immutable API and gives the user the control so change SSL context options during runtime. To be honest I'm not sure this is actually needed immediately. As such, #52 only adds the context options to the constructors of the respective connectors, without otherwise affecting the current API. I believe this to be a (c)leaner alternative, without forestalling future API changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress. The current state is provided in the hope to spark a discussion about this API. This is an alternative approach to #17 in order to achieve a better separation of concerns and to leave the current API unchanged. See also the discussion in #4 for some background.
This PR builds on top of #43, so the diff also includes its changes. Look here for changes only related to this PR alone.(no longer applies after rebasing)Fixes #4
Supersedes/closes #17