fix: added ignore list for autothread channels on xCancel Generation#515
Open
asbedb wants to merge 1 commit intoreactiflux:mainfrom
Open
fix: added ignore list for autothread channels on xCancel Generation#515asbedb wants to merge 1 commit intoreactiflux:mainfrom
asbedb wants to merge 1 commit intoreactiflux:mainfrom
Conversation
PR Summary
|
vcarl
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved a race condition between
promotionThreadandxCancelGeneratorthat caused duplicate or misaligned bot responses in specific channels.Problem
When a user posts a link in a channel managed by both handlers, a race condition occurs. The xCancelGenerator would trigger on the main message simultaneously with the thread creation, leading to fragmented bot responses and formatting issues within the newly created threads.

Solution
Implemented a check to ensure
xCancelGeneratorlogic is skipped in channels wherepromotionThreadis active. This ensures the two features are mutually exclusive at the channel level, while still allowing the converter to run in standard text channels.Potential Future Optimisations.
Centralized Config: Export the handler-to-channel mappings from index.ts as a shared constant. This would provide a single source of truth for channel-specific logic and prevent hardcoding ID lists across multiple generators.