Fixed issue of incorrectly getting the height/width on Android devices.

[ifsnow]

I found RN has 2 metrics(window/screen) in Dimensions.
I don't exactly know why these exist. It makes people feel confused.

• iOS : Dimensions.get("window") == Dimensions.get("screen")
• Android : Dimensions.get("window") != Dimensions.get("screen")

react-native-extra-dimensions-android uses screen values. so, If screen values are used internally, we do not need to use any other library and pass the props. This patched version works well on the device where the problem occurred.

I hope this helps.

[mmazzarolo]

Hey!
As far as I know react-native-extra-dimensions-android doesn't just use screen, it also ships native code

[mmazzarolo]

Related:
facebook/react-native#14887
facebook/react-native#20999

[ifsnow]

@mmazzarolo I thought so. But, You can see that the logic of react-native-extra-dimensions-android and react-native is the same and RN provides screen metrics.

Dimensions.get("screen").height == require("react-native-extra-dimensions-android").get("REAL_WINDOW_HEIGHT")

I have already checked if this version works as intended on various Android devices.
Please let me know you have any concerns about this.

[RichardLindhout]

I can confirm it too be working on the POC branch where the modals had space at the bottom.

[mmazzarolo]

@RichardLindhout do you mind do a quick check to see if this solution works as well?
Thank you.

[CarterBland]

I tested this branch and I'm still seeing an error.

[mmazzarolo]

@ifsnow I know I'm late, thanks again for submitting the PR but I'm closing it because we're still investigating which one of window and screen is the best option (they both works in different cases) and they can still be provided trough the deviceHeight and deviceWidth props manually.
Thanks for proposing the solution!