-
Notifications
You must be signed in to change notification settings - Fork 43
feat:Adding prettier as a dev dependency and formatting the whole code #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,26 +32,27 @@ | |
|
|
||
|  | ||
|
|
||
|
|
||
| ### Installation | ||
|
|
||
|
|
||
| 1. Clone the repo | ||
|
|
||
| ```sh | ||
| git clone https://github.com/react-native-elements/playground.git | ||
| cd playground | ||
| ``` | ||
|
|
||
| 2. Install NPM packages | ||
|
|
||
| ```sh | ||
| npm i | ||
| ``` | ||
|
|
||
| 3. Run the development server | ||
|
|
||
| ```sh | ||
|
Comment on lines
+45
to
52
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only spaces are added to the file? |
||
| npm start | ||
| ``` | ||
|
|
||
|
|
||
| ## Releated Projects | ||
|
|
||
| <a href="https://github.com/react-native-elements/react-native-elements"> | ||
|
|
@@ -66,19 +67,14 @@ npm start | |
|
|
||
| ## Documentation | ||
|
|
||
| [View the full docs of React Native elements here](https://reactnativeelements.com/docs/overview) | ||
| [View the full docs of React Native elements here](https://reactnativeelements.com/docs/overview) | ||
|
|
||
| ## Contributing | ||
|
|
||
|
|
||
|
|
||
|
|
||
| Interested in contributing to this repo? Check out our | ||
| [Contributing Guide](https://reactnativeelements.com/docs/contributing) | ||
| and submit a PR for a new feature/bug fix. | ||
|
|
||
|
|
||
|
|
||
| ### First Contributors | ||
|
|
||
| We encourage everyone to contribute & submit PR's especially first-time | ||
|
|
@@ -92,7 +88,6 @@ an | |
| or a | ||
| [pull request](https://github.com/react-native-elements/playground/pulls). | ||
|
|
||
|
|
||
| ### Slack Community | ||
|
|
||
| In case you have any other question or would like to come say **Hi!** to the RNE | ||
|
|
@@ -158,5 +153,3 @@ Do you use React Native Elements in production? If so, consider supporting this | |
| [](https://opencollective.com/react-native-elements/sponsor/17/website) | ||
| [](https://opencollective.com/react-native-elements/sponsor/18/website) | ||
| [](https://opencollective.com/react-native-elements/sponsor/19/website) | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,8 @@ | |
| "eject": "react-scripts eject", | ||
| "predeploy": "npm run build", | ||
| "deploy": "gh-pages -d build", | ||
| "postinstall": "patch-package" | ||
| "postinstall": "patch-package", | ||
| "format": "prettier --write \"**/*.{js,jsx,json,md}\"" | ||
|
Comment on lines
+34
to
+35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please avoid changing the packages.... (can cause merge conflict for others PR's) |
||
| }, | ||
| "eslintConfig": { | ||
| "extends": "react-app" | ||
|
|
@@ -54,6 +55,7 @@ | |
| "gh-pages": "^3.1.0", | ||
| "patch-package": "^6.2.2", | ||
| "postinstall-postinstall": "^2.1.0", | ||
| "prettier": "^2.2.1", | ||
| "react-app-rewired": "^2.1.6" | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
| "src": "logo512.png", | ||
| "type": "image/png", | ||
| "sizes": "512x512" | ||
| } | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ], | ||
| "start_url": ".", | ||
| "display": "standalone", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| import React from "react"; | ||
| import { SafeAreaInsetsContext, SafeAreaProvider } from 'react-native-safe-area-context'; | ||
| import { | ||
| SafeAreaInsetsContext, | ||
| SafeAreaProvider, | ||
| } from "react-native-safe-area-context"; | ||
|
|
||
| import Root from "./containers"; | ||
| import "./App.css"; | ||
|
Comment on lines
+2
to
8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't make any sense. only spaces have been added all over the place. |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import App from './App'; | ||
| import React from "react"; | ||
| import ReactDOM from "react-dom"; | ||
| import App from "./App"; | ||
|
|
||
| it('renders without crashing', () => { | ||
| const div = document.createElement('div'); | ||
|
Comment on lines
-1
to
-6
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. replacements |
||
| it("renders without crashing", () => { | ||
| const div = document.createElement("div"); | ||
| ReactDOM.render(<App />, div); | ||
| ReactDOM.unmountComponentAtNode(div); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,4 @@ export default function TilePlayground() { | |
| <Playground /> | ||
| </div> | ||
| ); | ||
| }; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import './index.css'; | ||
| import App from './App'; | ||
| import * as serviceWorker from './serviceWorker'; | ||
| import 'react-native-safe-area-context'; | ||
| import React from "react"; | ||
| import ReactDOM from "react-dom"; | ||
| import "./index.css"; | ||
| import App from "./App"; | ||
| import * as serviceWorker from "./serviceWorker"; | ||
| import "react-native-safe-area-context"; | ||
|
|
||
| ReactDOM.render(<App />, document.getElementById('root')); | ||
| ReactDOM.render(<App />, document.getElementById("root")); | ||
|
|
||
|
Comment on lines
+1
to
9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change will create conflict for other PR's |
||
| // If you want your app to work offline and load faster, you can change | ||
| // unregister() to register() below. Note this comes with some pitfalls. | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try making some change, adding spaces doesn't help