Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ Before filling out an issue:
> We highly recommend that you re-create the bug on [Snack](https://snack.expo.io). If not, list the steps that a reviewer can take to reproduce the behaviour:

Example:

**Snack** : https://snack.expo.io/xxx

- Steps

1. Go to '...'
Comment on lines 28 to 34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try making some change, adding spaces doesn't help

2. Click on '....'
3. Scroll down to '....'
Expand Down
17 changes: 5 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,27 @@

![React Native Elements UI Toolkit](https://github.com/react-native-elements/playground/blob/master/public/thumbnail.png)


### Installation


1. Clone the repo

```sh
git clone https://github.com/react-native-elements/playground.git
cd playground
```

2. Install NPM packages

```sh
npm i
```

3. Run the development server

```sh
Comment on lines +45 to 52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only spaces are added to the file?

npm start
```


## Releated Projects

<a href="https://github.com/react-native-elements/react-native-elements">
Expand All @@ -66,19 +67,14 @@ npm start

## Documentation

[View the full docs of React Native elements here](https://reactnativeelements.com/docs/overview)
[View the full docs of React Native elements here](https://reactnativeelements.com/docs/overview)

## Contributing




Interested in contributing to this repo? Check out our
[Contributing Guide](https://reactnativeelements.com/docs/contributing)
and submit a PR for a new feature/bug fix.



### First Contributors

We encourage everyone to contribute & submit PR's especially first-time
Expand All @@ -92,7 +88,6 @@ an
or a
[pull request](https://github.com/react-native-elements/playground/pulls).


### Slack Community

In case you have any other question or would like to come say **Hi!** to the RNE
Expand Down Expand Up @@ -158,5 +153,3 @@ Do you use React Native Elements in production? If so, consider supporting this
[![React Native Elements Backer](https://opencollective.com/react-native-elements/sponsor/17/avatar)](https://opencollective.com/react-native-elements/sponsor/17/website)
[![React Native Elements Backer](https://opencollective.com/react-native-elements/sponsor/18/avatar)](https://opencollective.com/react-native-elements/sponsor/18/website)
[![React Native Elements Backer](https://opencollective.com/react-native-elements/sponsor/19/avatar)](https://opencollective.com/react-native-elements/sponsor/19/website)


67 changes: 6 additions & 61 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"eject": "react-scripts eject",
"predeploy": "npm run build",
"deploy": "gh-pages -d build",
"postinstall": "patch-package"
"postinstall": "patch-package",
"format": "prettier --write \"**/*.{js,jsx,json,md}\""
Comment on lines +34 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid changing the packages.... (can cause merge conflict for others PR's)

},
"eslintConfig": {
"extends": "react-app"
Expand All @@ -54,6 +55,7 @@
"gh-pages": "^3.1.0",
"patch-package": "^6.2.2",
"postinstall-postinstall": "^2.1.0",
"prettier": "^2.2.1",
"react-app-rewired": "^2.1.6"
}
}
2 changes: 1 addition & 1 deletion public/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"src": "logo512.png",
"type": "image/png",
"sizes": "512x512"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • space again ?

],
"start_url": ".",
"display": "standalone",
Expand Down
5 changes: 4 additions & 1 deletion src/App.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import React from "react";
import { SafeAreaInsetsContext, SafeAreaProvider } from 'react-native-safe-area-context';
import {
SafeAreaInsetsContext,
SafeAreaProvider,
} from "react-native-safe-area-context";

import Root from "./containers";
import "./App.css";
Comment on lines +2 to 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make any sense. only spaces have been added all over the place.

Expand Down
10 changes: 5 additions & 5 deletions src/App.test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';
import React from "react";
import ReactDOM from "react-dom";
import App from "./App";

it('renders without crashing', () => {
const div = document.createElement('div');
Comment on lines -1 to -6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replacements " " to ' ' and vice-a-versa.

it("renders without crashing", () => {
const div = document.createElement("div");
ReactDOM.render(<App />, div);
ReactDOM.unmountComponentAtNode(div);
});
2 changes: 1 addition & 1 deletion src/components/playground/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default ({ params }) => {
<div
style={{
border: "1px dashed #ccc",
position:'relative'
position: "relative",
}}
>
<Compiler
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Drawer/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function ResponsiveDrawer(props) {
const [selectedIndex, setSelectedIndex] = React.useState(-1);

const handleDrawerToggle = (value) => {
if(value === false){
if (value === false) {
setMobileOpen(false);
} else {
setMobileOpen(true);
Expand Down
1 change: 0 additions & 1 deletion src/content/Slider/slider.playground.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
import Playground from "../../components/playground";
import { useView, PropTypes } from "react-view";


const SliderPlayground = () => {
const params = useView({
componentName: "Slider",
Expand Down
2 changes: 1 addition & 1 deletion src/content/Tile/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ export default function TilePlayground() {
<Playground />
</div>
);
};
}
8 changes: 5 additions & 3 deletions src/content/utils/createReactViewBaseConfig.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
export default function createReactViewBaseConfig(componentName, RNComponent) {
if (!componentName || !RNComponent) {
throw new Error('createBaseComponent needs a componentName name and RNComponent');
throw new Error(
"createBaseComponent needs a componentName name and RNComponent"
);
}

return ({
return {
componentName,
scope: {
RNComponent,
Expand All @@ -13,5 +15,5 @@ export default function createReactViewBaseConfig(componentName, RNComponent) {
named: [componentName],
},
},
});
};
}
14 changes: 7 additions & 7 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React from 'react';
import ReactDOM from 'react-dom';
import './index.css';
import App from './App';
import * as serviceWorker from './serviceWorker';
import 'react-native-safe-area-context';
import React from "react";
import ReactDOM from "react-dom";
import "./index.css";
import App from "./App";
import * as serviceWorker from "./serviceWorker";
import "react-native-safe-area-context";

ReactDOM.render(<App />, document.getElementById('root'));
ReactDOM.render(<App />, document.getElementById("root"));

Comment on lines +1 to 9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will create conflict for other PR's

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
Expand Down
6,379 changes: 6,378 additions & 1 deletion src/pages/home/animation.json

Large diffs are not rendered by default.

Loading