Skip to content

Add .prettierrc file fixes #56#57

Merged
pranshuchittora merged 1 commit intoreact-native-elements:masterfrom
jugshaurya:adding-prettier
Mar 26, 2021
Merged

Add .prettierrc file fixes #56#57
pranshuchittora merged 1 commit intoreact-native-elements:masterfrom
jugshaurya:adding-prettier

Conversation

@jugshaurya
Copy link
Contributor

@jugshaurya jugshaurya commented Mar 13, 2021 •
edited
Loading

fixes #56

@netlify
Copy link

netlify bot commented Mar 13, 2021 •
edited
Loading

Deploy preview for rne-playground ready!

Built with commit b77c2b8

https://deploy-preview-57--rne-playground.netlify.app

@Uyadav207 Uyadav207 mentioned this pull request Mar 13, 2021
Closed
@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 19, 2021

Can you setup Husky with Prettier in this PR?
Later you can do ESLint (later because we need to fix the guidelines before that via an RFC)

@Uyadav207 Uyadav207 mentioned this pull request Mar 20, 2021
Closed
@jugshaurya
Copy link
Contributor Author

jugshaurya commented Mar 20, 2021 •
edited
Loading

Can you setup Husky with Prettier in this PR?
Later you can do ESLint (later because we need to fix the guidelines before that via an RFC)

Yes sure @pranshuchittora, actually was working on it. Will add husky with prettier

And will add eslint to the project as well.
You can mark me assignee for this. Will make a pr today

jugshaurya
jugshaurya commented Mar 20, 2021
View reviewed changes
Copy link
Contributor Author

@jugshaurya jugshaurya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Husky and prettier for consistent styling across the codebase.

  • Imp: already ran prettier over all the files in the src directory via npm run format.
  • added format script for future reference
  • now complete codebase is consistent with styling via prettier.
  • and bad commits protected via husky.

Files added:

  • .prettierrc
  • .prettierignore
  • .vscode/recommendation.json [added prettier for contributor to recommend the prettier extension in vscode]

Husky running?
Yes
Screenshot from 2021-03-20 16-53-57

Folder structure

Screenshot from 2021-03-20 18-41-52

@pranshuchittora

@jugshaurya
Copy link
Contributor Author

jugshaurya commented Mar 20, 2021 •
edited
Loading

Added Husky and prettier for consistent styling across the codebase.

  • Imp: already ran prettier over all the files in the src directory via npm run format.
  • added format script for future reference
  • now complete codebase is consistent with styling via prettier.
  • and bad commits protected via husky.

fixes #56
@pranshuchittora please review

@jugshaurya
Add Prettier and Husky
b77c2b8 
- Imp: already ranned prettier over all the files in src directory via npm run format.
- added format script for future reference
- now complete codebase is consistent with styling via prettier.
- and bad commits protected via husky.
@jugshaurya
Copy link
Contributor Author

jugshaurya commented Mar 21, 2021

Also I want to work on adding eslint to project. Let me know when guideline rfc is updated. Will create a issue and pr for same as soon as you update me. Thanks.

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 26, 2021

LGTM :)
Thanks

@pranshuchittora pranshuchittora merged commit cf95af7 into react-native-elements:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tewarig tewarig tewarig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a .prettierrc file

3 participants

@jugshaurya @pranshuchittora @tewarig