Skip to content

updated home styling #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shivambalwani wants to merge 5 commits into from
Closed

updated home styling #23

shivambalwani wants to merge 5 commits into from

Conversation

@shivambalwani
Copy link

@shivambalwani shivambalwani commented Mar 10, 2021

fixed issue #3:
changed inline styling in home page to external styling

@netlify
Copy link

netlify bot commented Mar 10, 2021 •
edited
Loading

Deploy preview for rne-playground processing.

Building with commit 6cbf6a6

https://app.netlify.com/sites/rne-playground/deploys/60596c8ec0877c0008cdfd99

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 10, 2021

Thanks for the PR, but it's not recommended to use direct css due to name collisions.
Pls use the CSS module for the styling

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 10, 2021

Ref -> https://create-react-app.dev/docs/adding-a-css-modules-stylesheet/

@pranshuchittora pranshuchittora mentioned this pull request Mar 10, 2021
Merged
@shivambalwani
Copy link
Author

shivambalwani commented Mar 10, 2021 •
edited
Loading

Thanks for the PR, but it's not recommended to use direct css due to name collisions.
Pls use the CSS module for the styling

@pranshuchittora done👍

@iamsaumya iamsaumya mentioned this pull request Mar 10, 2021
Closed
pranshuchittora
pranshuchittora reviewed Mar 19, 2021
View reviewed changes
src/pages/home/home.module.css Outdated
.divider{
margin: 3vh 0;
}
.grid{
Copy link
Member

@pranshuchittora pranshuchittora Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name them more specifically

pranshuchittora
pranshuchittora reviewed Mar 19, 2021
View reviewed changes
src/pages/home/home.module.css Outdated
}


.paper{
Copy link
Member

@pranshuchittora pranshuchittora Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 19, 2021

All class names seems to generic, it would be great if they are more specific

pranshuchittora
pranshuchittora requested changes Mar 19, 2021
View reviewed changes
Copy link
Member

@pranshuchittora pranshuchittora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix class names

@shivambalwani
Copy link
Author

shivambalwani commented Mar 21, 2021

Fix class names

@pranshuchittora i have fixed the style naming, but the checks are failing. I don't know why?

@pranshuchittora
Copy link
Member

pranshuchittora commented Mar 26, 2021

Pls pull the new changes and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranshuchittora pranshuchittora pranshuchittora requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shivambalwani @pranshuchittora @flyingcircle