[Fix, Add] Fix New props import pattern, Added New components#118
Merged
pranshuchittora merged 1 commit intoreact-native-elements:masterfrom Jun 22, 2021
Merged
Conversation
|
👷 Deploy Preview for rne-playground processing. 🔨 Explore the source changes: 2b16301 🔍 Inspect the deploy log: https://app.netlify.com/sites/rne-playground/deploys/60c054cac03c780007d7486e |
| ); | ||
| exec("cp -r ./react-native-elements/website/docs/props ./src/content/Props"), | ||
| exec( | ||
| "cp -r ./react-native-elements/website/docs/main/props ./src/content/Props" |
Member
There was a problem hiding this comment.
Suggested change
| "cp -r ./react-native-elements/website/docs/main/props ./src/content/Props" | |
| "cp -r ./react-native-elements/website/docs/props ./src/content/Props" |
Contributor
There was a problem hiding this comment.
@pranshuchittora this file has some substantial changes in #97 please look there and this thing isn't a problem there! Please look at the PRs available. those PRs have to be merged before the latest ones. Otherwise, there will be conflicts. @pranshuchittora
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
FIxes the props import issue for the change in the main repo. Ref: [Refactor] docs directory structure react-native-elements#3071.
This PR also fixes the invalid import names of the playground for Text, AirBnBRating
Added playground for new components:
Did you add tests for your changes?
Not required
If relevant, did you update the documentation?
Yes
Summary
This PR fixes the prop import issue and adds new playground for new components added in the main package.
Does this PR introduce a breaking change?
Yes
Other information
Not required