Support esm with package.json routers #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like lint errors are unrelated. |
Member
|
On the runtime thing as well, see reactjs/react-transition-group#507. I think it's a bug in the Babel preset. |
Contributor
Author
|
Runtime is used for both cjs and esm here. |
Member
|
lint errors are expected, it's been in a bad state since #288 i've not quite gotten to it yet |
Member
|
Ah, I see – you're adding the runtime transform here. |
Similar to react-transition-group approach. Also added babel runtime and removed prop-types-extra package (which is not used already).
Contributor
Author
|
@jquense Lint is fixed. Could you merge? |
jquense
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to react-transition-group approach. Also added babel runtime with esm helpers.
Closes #282