Skip to content

address issue when running commands with #exec #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhh merged 1 commit into from
Aug 10, 2022
Merged

address issue when running commands with #exec #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/tasks/build.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ TAILWIND_COMPILE_COMMAND = "#{RbConfig.ruby} #{Pathname.new(__dir__).to_s}/../..
namespace :tailwindcss do
desc "Build your Tailwind CSS"
task :build do
exec TAILWIND_COMPILE_COMMAND
system(TAILWIND_COMPILE_COMMAND, exception: true)
end

desc "Watch and build your Tailwind CSS on file changes"
task :watch do
exec "#{TAILWIND_COMPILE_COMMAND} -w"
system "#{TAILWIND_COMPILE_COMMAND} -w"
Copy link

@jacob-carlborg-apoex jacob-carlborg-apoex Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason exception: true is not used here? Even though the command is not expected to terminate, it can still fail to start in the first place.

Copy link
Member

@flavorjones flavorjones Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason other than it hasn't been a problem we needed to solve. If you'd like to submit a PR I'd consider merging it.

end
end

Expand Down