Fix broken install in Rails 7 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably need a check on both, so this continues to work with Rails 6 as well. |
Contributor
Author
|
@dhh is this more like it? |
dhh
reviewed
Oct 7, 2021
Signed-off-by: Dane Wilson <[email protected]>
|
Can we get this merged @dhh? |
Collaborator
|
@mhenrixon Did you test if this fixes the problem? I'm gonna take a look later or tomorrow but it would be helpful if someone else also could test it |
|
Haven't had a chance to verify but judging from the error message from the installer I have a feeling it would help. Won't be able to test it for a bit. Just packing up my family and our home and moving across Germany on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation fails on Rails 7 since it uses the same application.js file as webpacker