fix: get pxe_enabled from BIOS setting instead of naming heuristic#1857
Open
fix: get pxe_enabled from BIOS setting instead of naming heuristic#1857
Conversation
stevekeay
changed the title
stevekeay
force-pushed
the
inspect-honour-bios-pxe-port
branch
2 times, most recently
from
7c90a9f to
c985b6f
Compare
stevekeay
force-pushed
the
inspect-honour-bios-pxe-port
branch
3 times, most recently
from
9bf139f to
96981fd
Compare
As part of the enrolment process we populate the BIOS setting for which NIC to use for PXE boot (HttpDev1Interface). This is likely to be the correct interface, so stop using the naming-convention heuristic in PortBiosNameHook to choose the PXE port and instead honour the setting that we pull from the BIOS. This now uses Ironic's built-in bios interface (task.driver.bios.cache_bios_settings) to populate the BIOS settings DB, then reads HttpDev1Interface via BIOSSetting.get() to determine which NIC to mark as the PXE port. The prefix-matching logic handles the case where the BIOS FQDD is more specific than the EthernetInterface identity (e.g. NIC.Integrated.1-1-1 vs NIC.Integrated.1-1).
stevekeay
force-pushed
the
inspect-honour-bios-pxe-port
branch
from
96981fd to
ab7bf21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the enrolment process we populate the BIOS setting for which NIC to use for PXE boot (HttpDev1Interface). This is likely to be the correct interface, so stop using the naming-convention heuristic in PortBiosNameHook to choose the PXE port and instead honour the setting that we pull from the BIOS.
Add a new BiosPxePortHook inspection hook that uses Ironic's built-in bios interface (task.driver.bios.cache_bios_settings) to populate the BIOS settings DB, then reads HttpDev1Interface via BIOSSetting.get() to determine which NIC to mark as the PXE port. The prefix-matching logic handles the case where the BIOS FQDD is more specific than the EthernetInterface identity (e.g. NIC.Integrated.1-1-1 vs NIC.Integrated.1-1).
PortBiosNameHook retains responsibility for setting the port name, extra.bios_name, physical_network and local_link_connection but no longer touches the pxe flag.