Skip to content

ci(shelllint): align PR linting with local ShellCheck runs#335

Merged
vnarapar merged 1 commit intoqualcomm-linux:mainfrom
smuppand:shell-lint-workflow
Mar 8, 2026
Merged

ci(shelllint): align PR linting with local ShellCheck runs#335
vnarapar merged 1 commit intoqualcomm-linux:mainfrom
smuppand:shell-lint-workflow

Conversation

@smuppand
Copy link
Contributor

@smuppand smuppand commented Mar 8, 2026

Summary
Update the shelllint workflow so pull requests lint only changed .sh files while reporting ShellCheck findings the same way they appear in local runs.

Changes

  • keep PR lint scoped to changed shell files only
  • remove the warning-only severity filter so style and info issues are also reported
  • keep workflow steps POSIX sh basedpin ShellCheck installation to 0.9.0-1
  • fetch enough git history for reliable PR diff detection

Result

  • Shell lint results in GitHub Actions now match the manual shellcheck -s sh ... behavior more closely, while preserving the existing PR-only changed-file flow.

Lint only changed shell files in pull requests, keep workflow steps in sh,
and report ShellCheck findings like local runs while pinning version 0.9.0-1.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand smuppand requested review from abbajaj806 and vnarapar March 8, 2026 07:07
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vnarapar vnarapar merged commit 940fc53 into qualcomm-linux:main Mar 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants