Arm backend: Remove test name convention and validation#18492
Arm backend: Remove test name convention and validation#18492martinlsm wants to merge 2 commits intopytorch:mainfrom
Conversation
It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I129db66db0d0c129313e41db4a719a77d74a8d96
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18492
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 3 Unrelated FailuresAs of commit 5965653 with merge base 93960e5 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
|
@pytorchbot label "release notes: none" |
There was a problem hiding this comment.
Pull request overview
Removes the Arm backend’s test-name convention enforcement by deleting the supporting validation/parsing scripts and removing the corresponding pre-push hook check.
Changes:
- Delete the Python utilities used to collect tests and validate Arm test naming conventions.
- Remove the “Test name checks” block from the Arm
pre-pushscript so the validation no longer runs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backends/arm/scripts/testname_rules/validate_test_names.py | Removed the CLI entrypoint that applied naming rules to collected tests. |
| backends/arm/scripts/testname_rules/parse_test_names.py | Removed the name parsing/validation logic and violation reporting types. |
| backends/arm/scripts/testname_rules/collect_tests.py | Removed AST-based test discovery used by the validator. |
| backends/arm/scripts/testname_rules/collect_testname_resources.py | Removed generation of allowed targets/ops/models/passes used by name parsing. |
| backends/arm/scripts/pre-push | Removed invocation of the test-name validation from the pre-push checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell