Skip to content

Arm backend: Remove test name convention and validation#18492

Open
martinlsm wants to merge 2 commits intopytorch:mainfrom
martinlsm:remove-test-name-validation
Open

Arm backend: Remove test name convention and validation#18492
martinlsm wants to merge 2 commits intopytorch:mainfrom
martinlsm:remove-test-name-validation

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Mar 25, 2026

It has been decided to remove test name convention because the benefit of it is not worth the maintenance cost. This patch removes test the validation script that was run by the pre-push hook.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

It has been decided to remove test name convention because the benefit
of it is not worth the maintenance cost. This patch removes test the
validation script that was run by the pre-push hook.

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: I129db66db0d0c129313e41db4a719a77d74a8d96
Copilot AI review requested due to automatic review settings March 25, 2026 12:42
@martinlsm martinlsm requested a review from digantdesai as a code owner March 25, 2026 12:42
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 25, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18492

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 5965653 with merge base 93960e5 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2026
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Mar 25, 2026
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Mar 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Arm backend’s test-name convention enforcement by deleting the supporting validation/parsing scripts and removing the corresponding pre-push hook check.

Changes:

  • Delete the Python utilities used to collect tests and validate Arm test naming conventions.
  • Remove the “Test name checks” block from the Arm pre-push script so the validation no longer runs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backends/arm/scripts/testname_rules/validate_test_names.py Removed the CLI entrypoint that applied naming rules to collected tests.
backends/arm/scripts/testname_rules/parse_test_names.py Removed the name parsing/validation logic and violation reporting types.
backends/arm/scripts/testname_rules/collect_tests.py Removed AST-based test discovery used by the validator.
backends/arm/scripts/testname_rules/collect_testname_resources.py Removed generation of allowed targets/ops/models/passes used by name parsing.
backends/arm/scripts/pre-push Removed invocation of the test-name validation from the pre-push checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed file is only used by pre-push no buck2 problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants