Skip to content

compileall: update for py39 #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
May 28, 2020
Merged

compileall: update for py39 #3956

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7eeeeb
compileall: add stripdir, prependdir and limit_sl_dest
Apr 29, 2020
e880264
compileall: compile_dir's default value is now None
Apr 29, 2020
2f984d3
compileall: update for current py39 (as of beta1)
May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions stdlib/3/compileall.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ else:

if sys.version_info >= (3, 7):
from py_compile import PycInvalidationMode

if sys.version_info >= (3, 9):
def compile_dir(
dir: _Path,
maxlevels: int = ...,
maxlevels: Optional[int] = ...,
ddir: Optional[_Path] = ...,
force: bool = ...,
rx: Optional[Pattern[Any]] = ...,
Expand All @@ -24,6 +26,10 @@ if sys.version_info >= (3, 7):
optimize: int = ...,
workers: int = ...,
invalidation_mode: Optional[PycInvalidationMode] = ...,
*,
stripdir: Optional[_Path] = ...,
prependdir: Optional[_Path] = ...,
limit_sl_dest: Optional[_Path] = ...,
) -> _SuccessType: ...
def compile_file(
fullname: _Path,
Expand All @@ -34,11 +40,29 @@ if sys.version_info >= (3, 7):
legacy: bool = ...,
optimize: int = ...,
invalidation_mode: Optional[PycInvalidationMode] = ...,
*,
stripdir: Optional[_Path] = ...,
Copy link
Member

@JelleZijlstra JelleZijlstra Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must actually be a string because it does stripdir.split(os.path.sep)

Copy link
Collaborator Author

@hauntsaninja hauntsaninja Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, contradicts the documentation. I filed https://bugs.python.org/issue40447

Copy link
Member

@JelleZijlstra JelleZijlstra May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the bug probably won't be fixed very soon, can you just change the stub for now?

prependdir: Optional[_Path] = ...,
limit_sl_dest: Optional[_Path] = ...,
Copy link
Member

@JelleZijlstra JelleZijlstra Apr 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But these two really can be PathLike

) -> _SuccessType: ...
def compile_path(
skip_curdir: bool = ...,
elif sys.version_info >= (3, 7):
def compile_dir(
dir: _Path,
maxlevels: int = ...,
ddir: Optional[_Path] = ...,
force: bool = ...,
rx: Optional[Pattern[Any]] = ...,
quiet: int = ...,
legacy: bool = ...,
optimize: int = ...,
workers: int = ...,
invalidation_mode: Optional[PycInvalidationMode] = ...,
) -> _SuccessType: ...
def compile_file(
fullname: _Path,
ddir: Optional[_Path] = ...,
force: bool = ...,
rx: Optional[Pattern[Any]] = ...,
quiet: int = ...,
legacy: bool = ...,
optimize: int = ...,
Expand Down Expand Up @@ -67,6 +91,18 @@ else:
legacy: bool = ...,
optimize: int = ...,
) -> _SuccessType: ...

if sys.version_info >= (3, 7):
def compile_path(
skip_curdir: bool = ...,
maxlevels: int = ...,
force: bool = ...,
quiet: int = ...,
legacy: bool = ...,
optimize: int = ...,
invalidation_mode: Optional[PycInvalidationMode] = ...,
) -> _SuccessType: ...
else:
def compile_path(
skip_curdir: bool = ...,
maxlevels: int = ...,
Expand Down