Conversation
PR #2833 introduced more flexible handling for the type of the default parameter, but the extra type variable caused some issues. Add another overload for the case where there is no default param. This is I think related to the issues we have had with `get` recently?
gvanrossum
reviewed
Mar 25, 2019
stdlib/2/__builtin__.pyi
Outdated
| @overload | ||
| def max(_arg1: _T, _arg2: _T, *_args: _T, key: Callable[[_T], Any] = ...) -> _T: ... | ||
| @overload | ||
| def max(_iterable: Iterable[_T], *, key: Callable[[_T], Any] = ...,) -> _T: ... |
Member
There was a problem hiding this comment.
Don't need a trailing , after the ....
stdlib/2/__builtin__.pyi
Outdated
| @overload | ||
| def max(_iterable: Iterable[_T], *, key: Callable[[_T], Any] = ...,) -> _T: ... | ||
| @overload | ||
| def max(_iterable: Iterable[_T], *, key: Callable[[_T], Any] = ..., default: _VT = ...) -> Union[_T, _VT]: ... |
Member
There was a problem hiding this comment.
Won't mypy still complain about calls without default= because this overload can still be called that way? (I.e. why not make default mandatory in this overload?
Contributor
Author
There was a problem hiding this comment.
mypy will take the first overload, I think, so the change did fix the issue, but I will make it mandatory
gvanrossum
approved these changes
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2833 introduced more flexible handling for the type of the default
parameter, but the extra type variable caused some issues. Add another
overload for the case where there is no default param.
This is I think related to the issues we have had with
getrecently?