Conversation
This comment has been minimized.
This comment has been minimized.
|
The runtime might include the symbols in |
This comment has been minimized.
This comment has been minimized.
This reverts commit 9a923a0.
This comment has been minimized.
This comment has been minimized.
|
I've disabled stubtest for now. Alternatively we could remove |
This comment has been minimized.
This comment has been minimized.
stubs/aiofiles/METADATA.toml
Outdated
| # Currently we are in a pickle, because aiofiles.os.__all__ is incorrect at | ||
| # runtime when running on win32. (https://github.com/Tinche/aiofiles/pull/174) | ||
| # This means that stubtest is either correct on Windows or all other platforms. | ||
| skip = true |
There was a problem hiding this comment.
Surely we don't need to skip stubtest entirely for the whole package. Can't we just create a stubtest_allowlist_win32.txt file in the @tests directory with three allowlist entries, aiofiles.os.__all__, aiofiles.os.sendfile and aiofiles.os.statvfs?
There was a problem hiding this comment.
I didn't know we could have architecture-specific allowlists! Will change accordingly.
There was a problem hiding this comment.
Embarrassingly, aiofiles already has architecture-specific allowlists ... 😳
This reverts commit b894a10.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
3 participants
Closes: #10551