-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 817: Wheel Variants: Beyond Platform Tags #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Oh thanks @hugovk I totally didn't see that one being published within 20min :D Let me know which number you want me to pick and I'll do the update ;) |
|
Thanks! @DEKHTIARJonathan You may continue with 817. |
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very brief review, I haven't yet read beyond the end of Motivation.
A
|
Just a brief bystander comment: I'm so stoked to see this PEP draft published! |
Co-authored-by: Adam Turner <[email protected]>
Thanks Jannis! Took some significant amount of work but we eventually got there |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
e34e8fa to
64f32ed
Compare
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Reflow the text to restore correct text width after all the inline changes and applied suggestions. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Remove accidental double spaces that vim's `gq` introduced while I was reflowing the text. Thanks to @konstin for noticing. Signed-off-by: Michał Górny <[email protected]>
| enabling the optional provider or selecting the variant explicitly. | ||
|
|
||
|
|
||
| Package ABI matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super excited about this one by the way :D
This reverts commit 261704f. Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Co-authored-by: Ralf Gommers <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Environment marker usage and optionality is described in "Providers" section. Let's limit "Provider information" only to technical field details themselves. Signed-off-by: Michał Górny <[email protected]>
|
I took a brief break over Christmas, aiming to look over the updates tomorrow (Saturday 3rd). A |
|
Thanks. At this point, it might be easier to look through the whole thing. I'm really looking forward to feedback whether the new version, when read top-to-bottom, makes concepts clearer without having to go back and forth, as it was necessary with the previous version. |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-HistoryCC: @mgorny @konstin @rgommers @atalman @charliermarsh @msarahan @seemethere @warsaw @dstufft @aterrel
📚 Documentation preview 📚: https://pep-previews--4740.org.readthedocs.build/pep-0817/