Expand environment variables in cache_dir config#7022
Merged
JukkaL merged 1 commit intopython:masterfrom Jul 24, 2019
Merged
Conversation
The 'cache_dir' configuration option will expand environment variables in addition to the user home directory. This makes it much easier to integrate with wrapper tools that use mypy.
Contributor
Author
|
Hi. Just pinging this thread to get some feedback as per the contributors documentation. Is it preferable to submit an issue linked to this pull request for the discussion? |
JukkaL
approved these changes
Jul 24, 2019
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
This seems reasonable. Thanks for the PR -- and sorry for the delay in reviewing this!
offbyone
added a commit
to offbyone/mypy
that referenced
this pull request
Mar 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further extends parsing of the 'cache_dir' configuration option (as originally introduced by #6651) to do environment variable expansion in addition to user home directory expansion. This makes it much easier to integrate mypy with other tools as well as making it possible to create more generic configuration files.