Format many-itemed tuples and unions consistently and more clearly#3893
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Aug 31, 2017
Merged
Format many-itemed tuples and unions consistently and more clearly#3893ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi merged 2 commits intopython:masterfrom
Conversation
added 2 commits
August 30, 2017 16:50
This allows callers of .bare_format (who need to perform post-processing before wrapping a type in quotes) to more easily match the quoting patterns used by other callers.
When the string representation of a tuple or union is too long to display, a shorter representation is used. This moves from two different representations to `<tuple: N items>` and `<union: N items>`, and consistently does not quote them.
Contributor
Author
|
This comes out of the conversation @ilevkivskyi and I had in #3873 (the relevant comments start here: #3873 (comment)). |
ilevkivskyi
approved these changes
Aug 31, 2017
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! This looks right. It is consistent with uses of <...> for absent/cropped output in other situations.
If there are no objections, then I will merge this soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the string representation of a tuple or union is too long to display, a shorter representation is used. This moves from two different representations to
<tuple: N items>and<union: N items>, and consistently does not quote them.This also includes a refactoring of the quoting logic in to a separate method, which enables the quoting of star arguments consistently with other types.