Conversation
Some of these are currently skipped because they are crashing. Add more descriptive names to existing --quick test cases. Also minor tweaks to existing test cases.
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Basically LGTM. You can address the issues below or not and merge this yourself.
| [stale a, b, builtins] | ||
|
|
||
| [case testQuickAndDirty4] | ||
| [case testQuickAndDirtyIntroduceErrorToExistingFunction] |
There was a problem hiding this comment.
Actually this test seems to clear an existing error. So maybe FixErrorInExistingFunction?
| [stale] | ||
|
|
||
| [case testQuickAndDirty6] | ||
| [case testQuickAndDirtyExistingError] |
| [stale] | ||
|
|
||
| [case testQuickAndDirty7] | ||
| [case testQuickAndDirtyIntroduceReferencesWithinCycle] |
There was a problem hiding this comment.
This test and the next also introduce errors (due to reveal_type()) in the cycle -- maybe we need separate tests that introduce references without the errors?
There was a problem hiding this comment.
Added two additional test cases
| [file b.py] | ||
| from typing import TypeVar, Generic | ||
| import a | ||
|
|
There was a problem hiding this comment.
No need for blank lines in this file IMO. (Same in the next test.)
| [file b.py] | ||
| def f() -> None: pass | ||
| [delete b.py.2] | ||
| [file c.py] |
| @@ -2285,7 +2289,7 @@ S = str | |||
| import b | |||
| def f(x: b.S) -> int: return 0 | |||
There was a problem hiding this comment.
The remaining tests don't have [rechecked] and [stale] fields -- not sure if this is intentional?
There was a problem hiding this comment.
Yes, they seemed to not add value when multiple test cases are very similar. I double checked and added those when they actually seemed useful.
* master: Improve test output when a test doesn't specify the correct fixture (python#3488) Speed up tests by simplifying the stub for typing (python#3486) Clean up test fixtures (python#3485) Add additional quick mode test cases (python#3480) Add --strict-optional on by default to roadmap (python#3478) Minor speed-up in warn-return-any (python#3481)
2 participants
Some of these are currently skipped because they are crashing.
Add more descriptive names to existing --quick test cases.
Also minor tweaks to existing test cases.