Remove special case for Union type context#20610
Merged
hauntsaninja merged 3 commits intopython:masterfrom Jan 21, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Kind of reverts python#2715. The test cases in that PR still pass Fixes python#20608
hauntsaninja
force-pushed
the
removesimplify
branch
from
2eaa35c to
761b29c
Compare
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
commented
Jan 18, 2026
| else_map, e.else_expr, context=ctx, allow_none_return=allow_none_return | ||
| ) | ||
| ctx = make_simplified_union([ctx_if_type, ctx_else_type]) | ||
| if has_ambiguous_uninhabited_component(ctx_if_type): |
Collaborator
Author
There was a problem hiding this comment.
without this change, testUnificationDictWithEmptyListLeft and testUnificationDictWithEmptyListRight start failing
JukkaL
approved these changes
Jan 21, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, this was a tricky one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts some of #2715. The test cases introduced in that PR still pass
Fixes #20608
Test case minimised by A5rocks
Codex assisted in diagnosing the issue