[mypyc] Generate function wrappers for each callable class instance #20575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating callable classes for async functions, currently mypyc will generate a single
CPyFunctionwrapper for each callable class type. This results in incorrect behavior when the callable class is used as a wrapper because the@wraps(fn)decorator will set the__name__attribute of the callable class to name offn.If the callable class is instantiated multiple times, the name of previous instances will be overridden because all instances share the same
CPyFunctionwrapper which contains the name attribute.To fix this, the
CPyFunctionwrappers are generated for each instance of the callable class instead of for each type. The wrappers are stored as an attribute of the callable class and instantiated in the setup function.