Cleaner usage of get_proper_type()#13326
Merged
ilevkivskyi merged 18 commits intopython:masterfrom Aug 4, 2022
Merged
Conversation
Member
Author
|
Btw I think that I checked and "optimized" completely the usage of
Plus also some important places in |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: paasta (https://github.com/yelp/paasta)
- paasta_tools/instance/kubernetes.py:643: error: List item 1 has incompatible type "Task[List[TypedDict({'name'?: str, 'type'?: str, 'replicas'?: int, 'ready_replicas'?: int, 'create_timestamp'?: int, 'git_sha'?: str, 'image_version'?: Optional[str], 'config_sha'?: str, 'pods'?: Sequence[Mapping[str, Any]]})]]"; expected "Future[Dict[str, Any]]"
+ paasta_tools/instance/kubernetes.py:643: error: List item 1 has incompatible type "Task[List[KubernetesVersionDict]]"; expected "Future[Dict[str, Any]]"
|
Member
Author
|
TBH, I am not 100% sure how to explain the change in |
hauntsaninja
approved these changes
Aug 4, 2022
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Everything in this PR looks great, I didn't check to see if there are changes elsewhere that could be made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #13297
I move around some calls to
get_proper_type()to preserve original types as much as possible (plus few related required low-risk changes). This makes error messages much more concise, before some error messages in the tests I added were truly epic:cc @JukkaL