testcheck: auto-discovery of .test files#13142
Closed
odesenfans wants to merge 1 commit intopython:masterfrom
Closed
testcheck: auto-discovery of .test files#13142odesenfans wants to merge 1 commit intopython:masterfrom
odesenfans wants to merge 1 commit intopython:masterfrom
Conversation
Replaced the hardcoded list of test data files by an automatic discovery system that uses a glob expression on `check-*.test`. Fixes python#8650.
Member
|
I would propose to move on with #13143, that closes the same issue. Sorry for duplicate work. |
thijsmie
approved these changes
Jul 16, 2022
thijsmie
left a comment
thijsmie
left a comment
There was a problem hiding this comment.
I'm new to mypy so this review is purely in python context.
This looks mostly good to me. My only remark is that writing .parent.parent.parent is a bit "smelly" to me, maybe you could move the "root_dir" to the appropriate higher-level module and importing it from there. This makes this a bit more readable.
Author
|
@ilevkivskyi No worries, I totally agree. The other PR seems more complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the hardcoded list of test data files by an automatic
discovery system that uses a glob expression on
check-*.test.Fixes #8650.