Improve handling of overloads with ParamSpec#12953
Merged
hauntsaninja merged 2 commits intopython:masterfrom Jun 7, 2022
Merged
Improve handling of overloads with ParamSpec#12953hauntsaninja merged 2 commits intopython:masterfrom
ParamSpec#12953hauntsaninja merged 2 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Jun 7, 2022
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me, just had some nits
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
Thanks @hauntsaninja! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12922 (a crash report).
Mypy's logic for overlapping overloads currently doesn't account for the existence of
ParamSpecs. This PR fixes that.Test Plan
I added a test that ensures that the crash report in #12922 is fixed, and that ensures that basic type inference works as expected.
I'm not 100% confident I've covered all edge cases, but I think this is better than the status quo, anyway.