-
-
Notifications
You must be signed in to change notification settings - Fork 955
Add compiler warning tracking tooling failure remediation guidance #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hugovk
merged 7 commits into
python:main
from
nohlson:add-warning-tracking-tool-guidance
Aug 24, 2024
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
780b372
Add guidance for using warning tracking and remediate CI warning chec…
nohlson 3a6d880
Add links to files, general formatting improvements
nohlson db3ed48
Expand divider
nohlson cf4d962
Add formatting updates based on suggestions
nohlson f6395aa
Fix capitalization
nohlson 3aeb0c9
Add newline
nohlson 6ca97f8
Apply suggestions from code review
hugovk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ Development tools | |
| gdb | ||
| clang | ||
| coverity | ||
| warnings | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,53 @@ | ||||||
| .. warnings: | ||||||
|
|
||||||
| Tools for tracking compiler warnings | ||||||
| ==================================== | ||||||
|
|
||||||
| .. highlight:: bash | ||||||
|
|
||||||
| The compiler warning tracking tooling is intended to alert developers about new | ||||||
| compiler warnings introduced by their contributions. The tooling consists of | ||||||
| a Python script which is ran by the following GitHub workflows: | ||||||
|
|
||||||
| * Ubuntu/build and test (:cpy-file:`.github/workflows/reusable-ubuntu.yml`) | ||||||
| * macOS/build and test (:cpy-file:`.github/workflows/reusable-macos.yml`) | ||||||
|
|
||||||
| You can check the documentation for the :cpy-file:`Tools/build/check_warnings.py` tool | ||||||
| by running:: | ||||||
| python Tools/build/check_warnings.py --help | ||||||
|
|
||||||
| The script can be run locally by providing the compiler output and the | ||||||
| compiler output type to see a list of unique warnings. | ||||||
|
|
||||||
| :: | ||||||
hugovk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
|
|
||||||
| $ python Tools/build/check_warnings.py -c <compiler_output_file> -t <compiler_output_type> | ||||||
hugovk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
hugovk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
|
|
||||||
| .. | ||||||
|
|
||||||
| Note: `-fdiagnostics-format=json` flag is required when compiling with GCC | ||||||
|
||||||
| Note: `-fdiagnostics-format=json` flag is required when compiling with GCC | |
| Note: ``-fdiagnostics-format=json`` flag is required when compiling with GCC |
hugovk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
hugovk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.