Skip to content

bpo-46483: remove __class_getitem__ from pathlib.PurePath #30848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 7 commits into from
Feb 3, 2022
Merged

bpo-46483: remove __class_getitem__ from pathlib.PurePath #30848

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ee051d
bpo-46483: remove `__class_getitem__` from `pathlib.PurePath`
sobolevn Jan 24, 2022
472fb3d
Update 2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
sobolevn Jan 24, 2022
083550a
Update 2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
sobolevn Jan 24, 2022
651ae47
Delete 2022-01-23-11-17-48.bpo-46483.j7qwWb.rst
sobolevn Jan 24, 2022
2f4e1e1
Update 2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
sobolevn Jan 24, 2022
4c61ac7
Update Misc/NEWS.d/next/Library/2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
sobolevn Jan 24, 2022
8921861
Add entry to "What's new"
sobolevn Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from operator import attrgetter
from stat import S_ISDIR, S_ISLNK, S_ISREG, S_ISSOCK, S_ISBLK, S_ISCHR, S_ISFIFO
from urllib.parse import quote_from_bytes as urlquote_from_bytes
from types import GenericAlias


__all__ = [
Expand Down Expand Up @@ -691,8 +690,6 @@ def __ge__(self, other):
return NotImplemented
return self._cparts >= other._cparts

__class_getitem__ = classmethod(GenericAlias)

drive = property(attrgetter('_drv'),
doc="""The drive prefix (letter or UNC path), if any.""")

Expand Down
9 changes: 0 additions & 9 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2429,15 +2429,6 @@ def test_complex_symlinks_relative(self):
def test_complex_symlinks_relative_dot_dot(self):
self._check_complex_symlinks(os.path.join('dirA', '..'))

def test_class_getitem(self):
from types import GenericAlias

alias = self.cls[str]
self.assertIsInstance(alias, GenericAlias)
self.assertIs(alias.__origin__, self.cls)
self.assertEqual(alias.__args__, (str,))
self.assertEqual(alias.__parameters__, ())


class PathTest(_BasePathTest, unittest.TestCase):
cls = pathlib.Path
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove ``__class_getitem__`` from :class:`pathlib.PurePath`
Copy link
Member

@AlexWaygood AlexWaygood Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to:

  1. Give a one-sentence description of why it's being removed.
  2. Delete the news entry that was added in bpo-46483: change PurePath.__class_getitem__ to return GenericAlias #30822 (it'll make for a pretty confusing changelog otherwise).

Copy link
Member

@serhiy-storchaka serhiy-storchaka Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove ``__class_getitem__`` from :class:`pathlib.PurePath`
Remove ``__class_getitem__`` from :class:`pathlib.PurePath`.