Skip to content

bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 1 commit into from
Jul 27, 2017
Merged

bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c #2904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PC/clinic/msvcrtmodule.c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ msvcrt_open_osfhandle(PyObject *module, PyObject **args, Py_ssize_t nargs)
int flags;
long _return_value;

if (!_PyArg_ParseStack(args, nargs, ""_Py_PARSE_INTPTR"i:open_osfhandle",
if (!_PyArg_ParseStack(args, nargs, ""_Py_PARSE_UINTPTR"i:open_osfhandle",
&handle, &flags)) {
goto exit;
}
Expand Down Expand Up @@ -437,7 +437,7 @@ msvcrt_CrtSetReportFile(PyObject *module, PyObject **args, Py_ssize_t nargs)
void *file;
void *_return_value;

if (!_PyArg_ParseStack(args, nargs, "i"_Py_PARSE_INTPTR":CrtSetReportFile",
if (!_PyArg_ParseStack(args, nargs, "i"_Py_PARSE_UINTPTR":CrtSetReportFile",
&type, &file)) {
goto exit;
}
Expand Down Expand Up @@ -569,4 +569,4 @@ msvcrt_SetErrorMode(PyObject *module, PyObject *arg)
#ifndef MSVCRT_SET_ERROR_MODE_METHODDEF
#define MSVCRT_SET_ERROR_MODE_METHODDEF
#endif /* !defined(MSVCRT_SET_ERROR_MODE_METHODDEF) */
/*[clinic end generated code: output=e86cf578e7f1ffd2 input=a9049054013a1b77]*/
/*[clinic end generated code: output=66787cb934b8a3c2 input=a9049054013a1b77]*/
4 changes: 2 additions & 2 deletions PC/msvcrtmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
/*[python input]
class HANDLE_converter(CConverter):
type = 'void *'
format_unit = '"_Py_PARSE_INTPTR"'
format_unit = '"_Py_PARSE_UINTPTR"'

class HANDLE_return_converter(CReturnConverter):
type = 'void *'
Expand Down Expand Up @@ -65,7 +65,7 @@ class wchar_t_return_converter(CReturnConverter):
data.return_conversion.append(
'return_value = PyUnicode_FromOrdinal(_return_value);\n')
[python start generated code]*/
/*[python end generated code: output=da39a3ee5e6b4b0d input=2b25dc89e9e59534]*/
/*[python end generated code: output=da39a3ee5e6b4b0d input=d102511df3cda2eb]*/

/*[clinic input]
module msvcrt
Expand Down