Skip to content

bpo-31018: Switch to #pragma pack from __declspec(align) in _tracemalloc #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jul 25, 2017
Merged

bpo-31018: Switch to #pragma pack from __declspec(align) in _tracemalloc #2848

vstinner merged 1 commit into from
Jul 25, 2017

Conversation

@segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Jul 24, 2017 •
edited
Loading 

..\Modules\_tracemalloc.c(88): warning C4359: '<unnamed-tag>': Alignment specifier is less than actual alignment (8), and will be ignored.

The _tracemalloc frame_t packing optimization is not working in Windows x64.

For this to actually work we simply need to use #pragma pack instead.

https://bugs.python.org/issue31018

@segevfiner segevfiner mentioned this pull request Jul 24, 2017
Merged
5 tasks
@vstinner vstinner merged commit 3924377 into python:master Jul 25, 2017
@vstinner
Copy link
Member

vstinner commented Jul 25, 2017

Thanks. Packing is just an optimization to reduce the memory footprint. It's up to you to decide if it's worth it to backport the change to 3.6 (and maybe also 3.5).

@segevfiner segevfiner deleted the bpo-31018-tracemalloc-pack-optimization branch July 25, 2017 16:32
segevfiner added a commit to segevfiner/cpython that referenced this pull request Jul 25, 2017
@segevfiner
[3.6] bpo-31018: Switch to GH-pragma pack from __declspec(align) (pyt…
bf94bb7 
…honGH-2848)

(cherry picked from commit 3924377)
segevfiner added a commit to segevfiner/cpython that referenced this pull request Jul 25, 2017
@segevfiner
[3.5] bpo-31018: Switch to GH-pragma pack from __declspec(align) (pyt…
4d1c22e 
…honGH-2848)

(cherry picked from commit 3924377)
@segevfiner
Copy link
Contributor Author

segevfiner commented Jul 25, 2017

Since it's small... might as well.

vstinner pushed a commit that referenced this pull request Jul 25, 2017
@segevfiner @vstinner
[3.6] bpo-31018: Switch to GH-pragma pack from __declspec(align) (GH-…
d8b5216 
…2848) (#2868)

(cherry picked from commit 3924377)
vstinner pushed a commit that referenced this pull request Jul 25, 2017
@segevfiner @vstinner
[3.5] bpo-31018: Switch to GH-pragma pack from __declspec(align) (GH-…
49175b3 
…2848) (#2869)

(cherry picked from commit 3924377)
corona10 pushed a commit to corona10/cpython that referenced this pull request Jul 26, 2017
@segevfiner @corona10
[3.5] bpo-31018: Switch to GH-pragma pack from __declspec(align) (pyt…
b7a4f04 
…honGH-2848) (python#2869)

(cherry picked from commit 3924377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@segevfiner @vstinner @the-knights-who-say-ni