Skip to content

bpo-41218: Improve the test cases for test_compile_top_level_await_nocoro #21363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Jul 6, 2020
Merged

bpo-41218: Improve the test cases for test_compile_top_level_await_nocoro #21363

pablogsal merged 1 commit into from
Jul 6, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 6, 2020 •
edited
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jul 6, 2020
@pablogsal pablogsal changed the title bpo-41218: Improve the test cases for test_compile_top_level_await_no… bpo-41218: Improve the test cases for test_compile_top_level_await_nocoro Jul 6, 2020
@pablogsal pablogsal requested a review from ambv July 6, 2020 21:33
@pablogsal
Copy link
Member Author

pablogsal commented Jul 6, 2020

CC: @Carreau

@pablogsal pablogsal merged commit c2c1f1f into python:master Jul 6, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 6, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 6, 2020

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c2c1f1f906cdeb40576880d4b6a4f8fcbc016eb8 3.9

@pablogsal pablogsal deleted the bpo-41218 branch July 6, 2020 22:30
@miss-islington
Copy link
Contributor

miss-islington commented Jul 6, 2020

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c2c1f1f906cdeb40576880d4b6a4f8fcbc016eb8 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Jul 6, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 6, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@pablogsal @miss-islington
bpo-41218: Improve the test cases for test_compile_top_level_await_no…
32d1b53 
…_coro (pythonGH-21363)

(cherry picked from commit c2c1f1f)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 6, 2020

GH-21365 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 6, 2020

GH-21366 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@pablogsal @miss-islington
bpo-41218: Improve the test cases for test_compile_top_level_await_no…
3852753 
…_coro (pythonGH-21363)

(cherry picked from commit c2c1f1f)

Co-authored-by: Pablo Galindo <[email protected]>
miss-islington added a commit that referenced this pull request Jul 6, 2020
@miss-islington @pablogsal
bpo-41218: Improve the test cases for test_compile_top_level_await_no…
b71ff9a 
…_coro (GH-21363)

(cherry picked from commit c2c1f1f)

Co-authored-by: Pablo Galindo <[email protected]>
@Carreau
Copy link
Contributor

Carreau commented Jul 6, 2020

Thanks @pablogsal !

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020
@pablogsal @miss-islington
bpo-41218: Improve the test cases for test_compile_top_level_await_no…
708567e 
…_coro (pythonGH-21363)

(cherry picked from commit c2c1f1f)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Sep 4, 2020

GH-22109 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit that referenced this pull request Sep 5, 2020
@miss-islington @pablogsal
bpo-41218: Improve the test cases for test_compile_top_level_await_no…
a708ae7 
…_coro (GH-21363) (GH-22109)

(cherry picked from commit c2c1f1f)

Co-authored-by: Pablo Galindo <[email protected]>

Co-authored-by: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

Assignees

@pablogsal pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @Carreau @the-knights-who-say-ni