Skip to content

[3.8] bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (GH-18282) #18283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Jan 30, 2020
Merged

[3.8] bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (GH-18282) #18283

miss-islington merged 1 commit into from
Jan 30, 2020

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 30, 2020 •
edited by bedevere-bot
Loading

Skip test_zipfile.test_add_file_after_2107() if time.localtime()
fails with OverflowError. It is the case on AIX 6.1 for example.
(cherry picked from commit c232c91)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue39502

@vstinner @miss-islington
bpo-39502: Skip test_zipfile.test_add_file_after_2107() on AIX (pytho…
de1909b 
…nGH-18282)

Skip test_zipfile.test_add_file_after_2107() if time.localtime()
fails with OverflowError. It is the case on AIX 6.1 for example.
(cherry picked from commit c232c91)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jan 30, 2020
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 30, 2020
vstinner
vstinner approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 30, 2020

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b841633 into python:3.8 Jan 30, 2020
@miss-islington miss-islington deleted the backport-c232c91-3.8 branch January 30, 2020 15:05
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 30, 2020

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 30, 2020

@vstinner: Status check is done, and it's a success ✅ .

@EGuesnet EGuesnet mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot