[3.14] gh-143547: Fix PyErr_FormatUnraisable() fallback (#143557) #143603
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure. (cherry picked from commit 39a2bcf)
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 9, 2026
…GH-143557) (pythonGH-143603) pythongh-143547: Fix PyErr_FormatUnraisable() fallback (pythonGH-143557) Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure. (cherry picked from commit 1d0baf1ae48f98b61cc869a82e1b7206298f653f) Co-authored-by: Victor Stinner <[email protected]> (cherry picked from commit 39a2bcf)
|
GH-143612 is a backport of this pull request to the 3.13 branch. |
vstinner
added a commit
that referenced
this pull request
Jan 9, 2026
…H-143603) (#143612) [3.14] gh-143547: Fix PyErr_FormatUnraisable() fallback (GH-143557) (GH-143603) gh-143547: Fix PyErr_FormatUnraisable() fallback (GH-143557) Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure. (cherry picked from commit 1d0baf1) (cherry picked from commit 39a2bcf) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold a strong reference to 'hook' while calling the default unraisable took to log hook failure.
(cherry picked from commit 39a2bcf)
sys.unraisablehookfails and falls back to default logger #143547