-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-116738: Make lzma module thread-safe #142947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yoney
wants to merge
4
commits into
python:main
Choose a base branch
from
yoney:ft_lzma_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+47
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the attributes in lzma module thread-safe on the free-threading build. Attributes (check, eof, needs_input, unused_data) are now stored atomically or accessed via mutex-protected getters.
emmatyping
reviewed
Dec 19, 2025
Member
|
Looks like jobs failed due to a spurious GitHub outage. I've re-run the failed jobs. |
picnixz
reviewed
Dec 28, 2025
| "Data found after the end of the compressed stream."); | ||
|
|
||
| static PyObject * | ||
| Decompressor_unused_data_get(PyObject *op, void *Py_UNUSED(ignored)) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Decompressor_unused_data_get(PyObject *op, void *Py_UNUSED(ignored)) | |
| Decompressor_unused_data_get(PyObject *op, void *Py_UNUSED(closure)) |
I always think that Py_UNUSED(ignored) is not helpful. It's more meaningful to indicate what the parameter was meant to represent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the attributes in
lzmamodule thread-safe on the free-threading build. Attributes (check,eof,needs_input,unused_data) are now stored atomically or accessed via mutex-protected getters.Even though the operations are protected by locks, the attributes exposed via
PyMemberDef (check, eof, needs_input, unused_data)should still be updated atomically while holding the lock, or accessed via mutex‑protected getters, because they can be read without acquiring the lock.This issue was not addressed in #140711. A small addition that repeatedly reads these attributes shows the issue under tsan build.
cc: @mpage @colesbury