gh-142913: Add test case for interpreter generator w/ overridden opcodes #142911
+14,963
−645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
force-pushed
the
eval_loop_test
branch
from
e25709a to
40d5d70
Compare
DinoV
changed the title
DinoV
force-pushed
the
eval_loop_test
branch
7 times, most recently
from
85c6f7e to
506d4b6
Compare
DinoV
force-pushed
the
eval_loop_test
branch
3 times, most recently
from
80a2701 to
8fec3b0
Compare
DinoV
requested review from
a team,
AA-Turner,
emmatyping,
ericsnowcurrently,
erlend-aasland and
markshannon
as code owners
DinoV
force-pushed
the
eval_loop_test
branch
2 times, most recently
from
abb5095 to
c5caac6
Compare
mpage
reviewed
Jan 14, 2026
| Py_XDECREF(resumes); | ||
| return NULL; | ||
| } | ||
| PyObject *loads = PyLong_FromLong(Test_EvalFrame_Loads); |
Contributor
There was a problem hiding this comment.
I think we need to decref resumes here. IIRC PyDict_SetItemString doesn't steal a reference to the value; we would leak resumes without it.
| } | ||
| PyObject *loads = PyLong_FromLong(Test_EvalFrame_Loads); | ||
| if (loads == NULL || PyDict_SetItemString(res, "loads", loads) < 0) { | ||
| Py_XDECREF(loads); |
Contributor
There was a problem hiding this comment.
I think we need to decref res here too.
| Py_XDECREF(loads); | ||
| return NULL; | ||
| } | ||
| Test_EvalFrame_Resumes = Test_EvalFrame_Loads = 0; |
Contributor
There was a problem hiding this comment.
I think we need to decref loads before returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter generator has long supported giving it multiple bytecodes files where the latter files override opcodes defined in the earlier opcodes. This enables PEP 523 hook users to generate an interpreter loop using the existing opcodes and their own set of customizations. But there've been no test cases that validate this actually works.
This adds such a test case and fixes things up so this practically works. static functions used directly in the interpreter loop are moved into ceval.h. APIs which are used but not exported are marked as exported.
The generated test case is updated as mark of
mark regen-casesso it'll stay in sync as the bytecodes change.