Skip to content

Conversation

@lieryan
Copy link
Member

@lieryan lieryan commented Apr 4, 2024

Description

Some refactoring on movetest.py, adding type hints, and misc.

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@lieryan lieryan force-pushed the lieryan-refactor-movetest branch from 84c71bf to c70da6c Compare April 4, 2024 11:33
@codecov
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (186f2ed) to head (3be1fd4).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   94.86%   94.88%   +0.01%     
==========================================
  Files         135      135              
  Lines       26405    26403       -2     
==========================================
+ Hits        25050    25053       +3     
+ Misses       1355     1350       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lieryan lieryan force-pushed the lieryan-refactor-movetest branch from dca2e3b to 9ae39be Compare April 4, 2024 12:05
@lieryan lieryan enabled auto-merge April 4, 2024 12:15
@lieryan lieryan disabled auto-merge April 4, 2024 12:15
@lieryan lieryan merged commit 3ad5861 into master Apr 4, 2024
@lieryan lieryan deleted the lieryan-refactor-movetest branch April 4, 2024 12:19
@lieryan lieryan added this to the 1.14.0 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants